Messages in this thread | | | Date | Mon, 9 Feb 2009 16:27:12 -0500 | Subject | Re: ima changes to shmem breaks !CONFIG_SHMEM | From | Mike Frysinger <> |
| |
On Mon, Feb 9, 2009 at 16:23, James Morris wrote: > On Mon, 9 Feb 2009, Mike Frysinger wrote: >> commit 1df9f0a73178718969ae47d813b8e7aab2cf073c broke default building >> for Blackfin systems: >> CC mm/shmem.o >> mm/shmem.c: In function 'shmem_zero_setup': >> mm/shmem.c:2670: error: implicit declaration of function 'ima_shm_check' >> make[1]: *** [mm/shmem.o] Error 1 >> >> that's because the ima.h include was added behind the CONFIG_SHMEM >> markings rather than everywhere, just like the function is used. > > Does this seem like the correct fix?
it converts the build error to a build warning: CC mm/shmem.o In file included from mm/shmem.c:32: include/linux/ima.h:25: warning: 'struct linux_binprm' declared inside parameter list include/linux/ima.h:25: warning: its scope is only this definition or declaration, which is probably not what you want -mike
| |