Messages in this thread | | | Date | Mon, 9 Feb 2009 17:10:42 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/2] User access to internal clocks |
| |
On Mon, Feb 09, 2009 at 06:04:29PM +0100, Davide Rizzo wrote: > To: Greg KH <gregkh@suse.de> > Cc: "Hans J. Koch" <hjk@linutronix.de>, linux-kernel@vger.kernel.org, > ben-linux@fluff.org, linux-api@vger.kernel.org > > This driver is for user level programs to interact with system clocks. > It allows to read and modify rates and parents, using virtual files. > It requires the implementation of 2 additional functions in the clk interface: > clk_for_each() and clk_name(). > Actually I implemented that functions only for Samsung S3C24xx platform.
NAK.
> + name = clk_get_name(clk);
This implies that there is a 1:1 relationship between a 'name' and a struct clk. No such thing exists (and where it does, it's being eliminated in ARM because it's just plain and simple WRONG.)
| |