lkml.org 
[lkml]   [2009]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tun: Fix unicast filter overflow
From
Date
On Sun, 2009-02-08 at 17:06 -0800, David Miller wrote:
> From: Alex Williamson <alex.williamson@hp.com>
> Date: Sat, 07 Feb 2009 10:45:13 -0700
>
> > Tap devices can make use of a small MAC filter set via the
> > TUNSETTXFILTER ioctl. The filter has a set of exact matches
> > plus a hash for imperfect filtering of additional multicast
> > addresses. The current code is unbalanced, adding unicast
> > addresses to the multicast hash, but only checking the hash
> > against multicast addresses. This results in the filter
> > dropping unicast addresses that overflow the exact filter.
> > The fix is simply to disable the filter by leaving count set
> > to zero if we find non-multicast addresses after the exact
> > match table is filled.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@hp.com>
>
> Doesn't it make more sense to remove the multicast check
> in the filter check function?
>
> With your change, the user gets absolutely no indication
> that filtering has been completely disabled simply because
> they put too many unicast addresses into the filter. We
> just return zero, that's crazy.

Sure, that's another option, but we'd then need to figure out what to do
with TUN_FLT_ALLMULTI. Unicast would almost needs it's own hash list if
we want to support an allmulti mode that's less than promiscuous. The
return value of the ioctl is the number of exact filters, so the user
will know what happened. Thanks,

Alex




\
 
 \ /
  Last update: 2009-02-09 02:47    [from the cache]
©2003-2011 Jasper Spaans