lkml.org 
[lkml]   [2009]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume
    Hi!

    > > > their standard config spaces are restored. Fix this by not attempting
    > > > to disable bridges during suspend and enable them during resume.
    > > ...
    > > > @@ -428,16 +428,18 @@ static int pci_pm_default_resume(struct
    > > > {
    > > > pci_fixup_device(pci_fixup_resume, pci_dev);
    > > >
    > > > - if (!pci_is_bridge(pci_dev))
    > > > - pci_enable_wake(pci_dev, PCI_D0, false);
    > > > + if (pci_is_bridge(pci_dev))
    > > > + return 0;
    > > >
    > > > + pci_enable_wake(pci_dev, PCI_D0, false);
    > > > return pci_pm_reenable_device(pci_dev);
    > > > }
    > >
    > > Are you sure? This goes from doing reenable_device to not doing it for
    > > bridges, seemingly contradicting changelog?
    >
    > Can you explain what you mean, please?

    It looks to me like the patch does not match the changelog.

    Changelog says "enable bridge during resume", but code does return 0
    if it seems bridge.
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-02-08 10:15    [W:0.020 / U:90.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site