lkml.org 
[lkml]   [2009]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Soft lockup in sungem on Netra AC200 when switching interface up
From
From: Ilkka Virta <itvirta@iki.fi>
Date: Fri, 6 Feb 2009 13:29:02 +0200

> Looking at gem_do_start() and gem_open(), it seems that the only thing
> done while opening the device after the request_irq(), is a call to
> napi_enable().
>
> I don't know what the ordering requirements are for the
> initialization, but I boldly tried to move the napi_enable() call
> inside gem_do_start() before the link state is checked and interrupts
> subsequently enabled, and it seems to work for me. Doesn't even break
> anything too obvious...
>
> Any ideas on how this really should be fixed?

Actually your fix looks good, I'll apply this :-)

Thanks!


\
 
 \ /
  Last update: 2009-02-07 07:03    [W:0.051 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site