Messages in this thread | | | Date | Sat, 7 Feb 2009 11:52:19 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] i2c: add missing KERN_* constants to printks |
| |
On Sat, Feb 07, 2009 at 11:37:48AM +0100, Frank Seidel wrote: > Jean Delvare wrote: > > Default log level? That's news to me. Care to elaborate? > > printk (in kernel/printk.c) uses vprintk and vprintk: > asmlinkage int vprintk(const char *fmt, va_list args) > { > int printed_len = 0; > int current_log_level = default_message_loglevel; > ... > and default_message_loglevel in include/linux/kernel.h: > > #define default_message_loglevel (console_printk[1]) > > and console_printk[1] is (in kernel/printk.c) > DEFAULT_MESSAGE_LOGLEVEL > > and in kernel/printk.c: > #define DEFAULT_MESSAGE_LOGLEVEL 4 /* KERN_WARNING */ > > => so as far as i could see KERN_WARNING is the > default loglevel of messages. one little note: This is changable writing to /proc/sys/kernel/printk.
So the patch introduces at least a little change in behaviour. IMHO this is OK though.
Best regards Uwe
| |