lkml.org 
[lkml]   [2009]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] twl4030-gpio: Fix getting the value of the TWL4030 GPIO output pin
    Date
    On Friday 06 February 2009, Joonyoung Shim wrote:
    > If TWL4030 GPIO pin is output, must read the value from REG_GPIODATAOUTx
    > register in twl4030_get_gpio_datainout().

    Why "must"? The goal is to return the *actual* value of the pin,
    not the intended one. When an external signal overwhelms the drive
    capability of that GPIO -- just a couple mA -- the correct value
    to return can't be the value written in the output register.

    Plus, this patch won't even link ... you changed the name of the
    function at its definition, but not at its use points.

    NAK, unless you can show there's a real bug this addresses...

    - Dave


    \
     
     \ /
      Last update: 2009-02-07 09:03    [W:0.034 / U:118.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site