Messages in this thread | | | Date | Fri, 06 Feb 2009 17:57:38 +0900 | From | Kenji Kaneshige <> | Subject | Re: [PATCHv2] PCI: add missing KERN_* constants to printks |
| |
Frank Seidel wrote: > Kenji Kaneshige wrote: >> How about below. I think we can write printk in one line. >> >> #define dbg(format, arg...) \ >> do { \ >> if (pciehp_debug) \ >> printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg); \ >> } while (0) > > I wanted to keep the change as simple as possible and didn't wanna > play with surrounding indentation. But yes, if thats preferred... > i gonna change the patch to this. Shall i? >
I prefer it. I don't think it's so complex. And I can review and test shpchp/pciehp part of your patch on my machine.
Thanks, Kenji Kaneshige
| |