lkml.org 
[lkml]   [2009]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCHv2] PCI: add missing KERN_* constants to printks
Hi,

I have some minor comments below.

Frank Seidel wrote:
(snip.)
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
> #define dbg(format, arg...) \
> do { \
> if (pciehp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)

How about below. I think we can write printk in one line.

#define dbg(format, arg...) \
do { \
if (pciehp_debug) \
printk(KERN_DEBUG "%s: " format, MY_NAME, ## arg); \
} while (0)

> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
> #define dbg(format, arg...) \
> do { \
> if (shpchp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)

Ditto.

Thanks,
Kenji Kaneshige




\
 
 \ /
  Last update: 2009-02-06 09:07    [W:0.066 / U:0.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site