Messages in this thread | | | Date | Fri, 6 Feb 2009 11:28:43 -0500 | From | Jason Baron <> | Subject | Re: [Patch 0/2] dynamic debug |
| |
On Fri, Feb 06, 2009 at 12:54:26PM +1100, Greg Banks wrote: > > ok, patch below resolves the space issue. > > > > The above patch makes the output much easier for a human to read, which > is good. > > However it's half the job. The parser for the language used when > writing to the control file still uses whitespace to tokenize and is > still too dumb to handle quoting and so needs all whitespace escaped, > like this > > #echo -n 'format Setting\040node\040for\040non-present\040cpu +p' > /mnt/debugfs/dynamic_debug/control > > Which is documented in the howto. So that you could copy-n-paste in a > terminal window, I chose to make the input and output formats as similar > as possible, and used escaping for all whitespace on output. That was > just me being lazy, sorry. Below is a patch which implements a better > solution, which is to fix ddebug_tokenize() to handle simple quoting so > the above would look like > > #echo -n 'format "Setting node for non-present cpu" +p' > /mnt/debugfs/dynamic_debug/control > >
agreed. patch looks good...and I've tested it.
Greg KH, to be clear, Greg Banks patch applies on top of the additional patch which I sent.
thanks,
-Jason
| |