Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag | Date | Thu, 05 Feb 2009 11:27:10 +0100 |
| |
Floris Kraak <randakar@gmail.com> writes:
> Example: > > kernel/power/main.c:717: warning: format not a string literal and no > format arguments > > This complains about: > .. > if (!rtc) { > printk(warn_no_rtc); > goto done; > } > .. > > So what is this "warn_no_rtc" thing? > > static char warn_no_rtc[] __initdata = > KERN_WARNING "PM: no wakealarm-capable RTC driver is ready\n";
Does it help to make it const?
> That's pretty much GCC failing to recognize that the format is a > string literal and then complaining that it isn't.
Since it's a non-const variable it cannot be a string literal.
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |