lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm patch] Show memcg information during OOM (v3)
    Li Zefan wrote:
    >> + mem_cgrp = memcg->css.cgroup;
    >> + task_cgrp = mem_cgroup_from_task(p)->css.cgroup;
    >
    > I just noticed since v2, task's cgroup is also printed. Then 2 issues here:
    >
    > 1. this is better: task_cgrp = task_subsys_state(p, mem_cgroup_subsys_id);

    sorry, s/task_subsys_state/task_cgroup/

    > 2. getting cgroup from a task should be protected by task_lock or rcu_read_lock,
    > so we can put the above statement inside rcu_read_lock below.


    \
     
     \ /
      Last update: 2009-02-06 04:13    [W:0.020 / U:2.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site