Messages in this thread | | | Date | Fri, 6 Feb 2009 03:41:21 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH tip 1/2] ring_buffer: remove unused flags parameter |
| |
On Thu, Feb 05, 2009 at 11:48:40PM -0200, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 05, 2009 at 11:17:02PM +0100, Frederic Weisbecker escreveu: > > On Thu, Feb 05, 2009 at 04:12:56PM -0200, Arnaldo Carvalho de Melo wrote: > > > Impact: API change, cleanup > > > > > > From ring_buffer_{lock_reserve,unlock_commit}. > > > > > > Cc: Ingo Molnar <mingo@elte.hu> > > > Cc: Frédéric Weisbecker <fweisbec@gmail.com> > > > Cc: Jens Axboe <jens.axboe@oracle.com> > > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > > --- > > > block/blktrace.c | 8 +++--- > > > include/linux/ring_buffer.h | 9 ++---- > > > kernel/trace/kmemtrace.c | 12 +++----- > > > kernel/trace/ring_buffer.c | 9 +----- > > > kernel/trace/trace.c | 56 +++++++++++++------------------------ > > > kernel/trace/trace_boot.c | 12 +++----- > > > kernel/trace/trace_branch.c | 7 ++--- > > > kernel/trace/trace_hw_branches.c | 6 ++-- > > > kernel/trace/trace_mmiotrace.c | 12 +++----- > > > kernel/trace/trace_power.c | 12 +++----- > > > 10 files changed, 51 insertions(+), 92 deletions(-) > > > > > > $ codiff /tmp/vmlinux.before /tmp/vmlinux.after > > > linux-2.6-tip/kernel/trace/trace.c: > > > trace_vprintk | -14 > > > trace_graph_return | -14 > > > trace_graph_entry | -10 > > > trace_function | -8 > > > __ftrace_trace_stack | -8 > > > ftrace_trace_userstack | -8 > > > tracing_sched_switch_trace | -8 > > > ftrace_trace_special | -12 > > > tracing_sched_wakeup_trace | -8 > > > 9 functions changed, 90 bytes removed, diff: -90 > > > > > > linux-2.6-tip/block/blktrace.c: > > > __blk_add_trace | -1 > > > 1 function changed, 1 bytes removed, diff: -1 > > > > > > /tmp/vmlinux.after: > > > 10 functions changed, 91 bytes removed, diff: -91 > > > > > > codiff... I didn't know this great tool! :-) > > My marketing dept is not so good, but since you liked it, I guess its > appropriate to point you to this, that is the only documentation > available about it and some of its friends, like pahole: > > https://ols2006.108.redhat.com/2007/Reprints/melo-Reprint.pdf
Oh thank you! :-)
> Now back to the Rostedts extended TODO list. > > - Arnaldo
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |