lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] x86: unify fixmap.h

* Gustavo F. Padovan <gustavo@las.ic.unicamp.br> wrote:

> This patch unify fixmap_32.h and fixmap_64.h into fixmap.h.
> Things that we can't merge now are using CONFIG_X86_{32,64}
> (e.g.:vsyscall and EFI)
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
> Acked-by: Glauber Costa <gcosta@redhat.com>
> ---
> arch/x86/include/asm/fixmap.h | 153 +++++++++++++++++++++++++++++++++++++-
> arch/x86/include/asm/fixmap_32.h | 119 -----------------------------
> arch/x86/include/asm/fixmap_64.h | 94 -----------------------
> 3 files changed, 151 insertions(+), 215 deletions(-)
> delete mode 100644 arch/x86/include/asm/fixmap_32.h
> delete mode 100644 arch/x86/include/asm/fixmap_64.h

Please split this patch up into 3 parts:

#1: "x86: prepare fixmap_32.h for unification"
#2: "x86: prepare fixmap_64.h for unification"
#3: "x86: mechanic unification of fixmap_32/64.h => fixmap.h"

ok?

That way it's reviewable what happened during the unification,
with the above patch it isnt.

Ingo


\
 
 \ /
  Last update: 2009-02-06 00:49    [W:0.044 / U:5.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site