lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip 1/2] ring_buffer: remove unused flags parameter

    On Thu, 5 Feb 2009, Frederic Weisbecker wrote:
    > >
    > > - event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry),
    > > - &irq_flags);
    > > + event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry));
    > > if (!event)
    > > goto out;
    > > entry = ring_buffer_event_data(event);
    > > tracing_generic_entry_update(&entry->ent, 0, 0);
    > > entry->ent.type = TRACE_POWER;
    > > entry->state_data = *it;
    > > - ring_buffer_unlock_commit(tr->buffer, event, irq_flags);
    > > + ring_buffer_unlock_commit(tr->buffer, event);
    > >
    > > trace_wake_up();
    > >
    > > --
    > > 1.6.0.6
    > >
    >
    >
    > I don't what Steven planned (or not) with this flag.
    > If it's not related to his lockless ring buffer project or anything, this
    > cleanup is welcome.

    The irq_flags is legacy from the original implementation. Arnaldo is just
    going through my todo list (without even me telling him what it is ;-)

    Now only if I can get Arnaldo to do the TODO list my wife gives me ;-)

    -- Steve



    \
     
     \ /
      Last update: 2009-02-05 23:41    [W:0.020 / U:0.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site