lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCHv2] PCI: add missing KERN_* constants to printks
    From: Frank Seidel <frank@f-seidel.de>

    According to kerneljanitors todo list all printk calls (beginning
    a new line) should have an according KERN_* constant.
    Those are the missing pieces here for the pci subsystem.

    Signed-off-by: Frank Seidel <frank@f-seidel.de>
    ---
    drivers/pci/hotplug/pciehp.h | 3 ++-
    drivers/pci/hotplug/shpchp.h | 3 ++-
    drivers/pci/intel-iommu.c | 2 +-
    3 files changed, 5 insertions(+), 3 deletions(-)

    --- a/drivers/pci/intel-iommu.c
    +++ b/drivers/pci/intel-iommu.c
    @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
    ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);

    if (ret)
    - printk("IOMMU: Failed to create 0-64M identity map, "
    + printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
    "floppy might not work\n");

    }
    --- a/drivers/pci/hotplug/pciehp.h
    +++ b/drivers/pci/hotplug/pciehp.h
    @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
    #define dbg(format, arg...) \
    do { \
    if (pciehp_debug) \
    - printk("%s: " format, MY_NAME , ## arg); \
    + printk(KERN_DEBUG "%s: " format, MY_NAME , \
    + ## arg); \
    } while (0)
    #define err(format, arg...) \
    printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
    --- a/drivers/pci/hotplug/shpchp.h
    +++ b/drivers/pci/hotplug/shpchp.h
    @@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
    #define dbg(format, arg...) \
    do { \
    if (shpchp_debug) \
    - printk("%s: " format, MY_NAME , ## arg); \
    + printk(KERN_DEBUG "%s: " format, MY_NAME , \
    + ## arg); \
    } while (0)
    #define err(format, arg...) \
    printk(KERN_ERR "%s: " format, MY_NAME , ## arg)



    \
     
     \ /
      Last update: 2009-02-05 19:05    [W:0.056 / U:30.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site