lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Make exported headers use strict posix types
Arnd Bergmann wrote:
> A number of standard posix types are used in exported headers, which
> is not allowed if __STRICT_KERNEL_NAMES is defined. Change them all
> to use the safe __kernel variant so that we can make __STRICT_KERNEL_NAMES
> the default.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> ---
> On Thursday 05 February 2009, H. Peter Anvin wrote:
>
>> I have been advocating for hacking headers_install for a while. That
>> takes care of the 106. The 15 *need* to be audited immediately, because
>> that is even likely to be actual manifest bugs.
>
> This is what I found, please review.
>

Indeed a lot of these look like real bugs, e.g. the use of off_t (which
may be 32 bits in userspace while __kernel_off_t is 64 bits.)

So these are, indeed, critical bug fixes and should go into 2.6.29.

Some of these changes may require changes in userspace code if userspace
has hacked around the problems. Those changes, though, really should
happen, too.

-hpa


\
 
 \ /
  Last update: 2009-02-05 18:59    [from the cache]
©2003-2011 Jasper Spaans