lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security (was: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag)

* Floris Kraak <randakar@gmail.com> wrote:

> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -112,7 +112,7 @@ print_context_stack(struct thread_info *tinfo,
> static void
> print_trace_warning_symbol(void *data, char *msg, unsigned long symbol)
> {
> - printk(data);
> + printk("%s", data);
> print_symbol(msg, symbol);
> printk("\n");

Arjan, the code above seems to be dead and never called. These methods:

static const struct stacktrace_ops print_trace_ops = {
.warning = print_trace_warning,
.warning_symbol = print_trace_warning_symbol,

are not used anywhere that i can see. Could you have a look at this please?

Ingo


\
 
 \ /
  Last update: 2009-02-05 15:55    [W:0.083 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site