lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] ptrace: reintroduce __ptrace_detach() as a callee of ptrace_exit()
On 02/04, Roland McGrath wrote:
>
> > No functional changes, preparation for the next patch.
> >
> > Move the "should we release this child" logic into the separate handler,
> > __ptrace_detach().
>
> My inclination is to use bool in new code for true/false return values,
> but I don't really care.
>
> Please canonicalize the comment formatting for your new comments.
>
> The preserved comment no longer makes sense, there is no "dead list" in
> that function. Make it a coherent comment at the top that explains the
> return value.

OK, I'll send the cleanup patch.

> Given its content, this function now better belongs in ptrace.c, I think.

I don't completely agree... This helper imho has nothing to do with
ptracing, except it does __ptrace_unlink(). But OK, I will move it
if you prefer. In that case we should export task_detached().

Oleg.



\
 
 \ /
  Last update: 2009-02-05 15:45    [W:0.074 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site