Messages in this thread | | | Subject | Re: [PATCH 7/7] PCI PM: Let the core be more careful with respect to drivers using new framework | From | Benjamin Herrenschmidt <> | Date | Thu, 05 Feb 2009 12:18:03 +1100 |
| |
> I don't know about ppc, but on x86 the pcibios hook is only supposed to > disable the device's interrupt link.
Right now on ppc, I may disable the clocks too, but then:
- As soon as you have implemented the new scheme, I'll replace all that with using the same hooks as ACPI so that won't be an issue anymore
- Today, it's probably a non issue too because none of the devices for which I have that sort of manual clock control also shares interrupts.
> Potentially, calling into the AML interpreter.
Right, but we are fixing that anyway with the noirq phase being AML safe by no ? :-)
> When we implement the changes discussed in the "PCI PM: Restore standard > config registers of all devices early" thread, that part will end up in > suspend_noirq.
Yup.
Cheers, Ben.
| |