Messages in this thread | | | Subject | Re: [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy_suspend | From | Benjamin Herrenschmidt <> | Date | Thu, 05 Feb 2009 08:38:22 +1100 |
| |
On Wed, 2009-02-04 at 11:14 +0100, Frans Pop wrote: > Benjamin Herrenschmidt wrote: > > Minor nit: Should the warning be preceeded by a message ? The reason is, > > right now, all we get is a backtrace, it doesn't actually tell you which > > device or driver caused it which makes it pretty pointless. > > > > I think you should add a printk(KERN_ERR... just before that which gives > > those informations along with a little blurb along the lines of "driver > > changed device state without saving config space state"). > > That is actually already included in the patch (through drv->suspend):
How so ? I've had such backtraces with no other info in my log...
Ben.
| |