[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch 30/33] ACPI: Do not modify SCI_EN directly
    2.6.28-stable review patch.  If anyone has any objections, please let us know.


    From: Rafael J. Wysocki <>

    commit 11e93130c7ce5228d484fd5e86f3984835d4256b upstream.

    According to the ACPI specification the SCI_EN flag is controlled by
    the hardware, which sets this flag to inform the kernel that ACPI is
    enabled. For this reason, we shouldn't try to modify SCI_EN
    directly. Also, we don't need to do it in irqrouter_resume(), since
    lower-level resume code takes care of enabling ACPI in case it hasn't
    been enabled by the BIOS before passing control to the kernel (which
    by the way is against the ACPI specification).

    Signed-off-by: Rafael J. Wysocki <>
    Signed-off-by: Len Brown <>
    Cc: Thomas Renninger <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/acpi/pci_link.c | 4 ----
    1 file changed, 4 deletions(-)

    --- a/drivers/acpi/pci_link.c
    +++ b/drivers/acpi/pci_link.c
    @@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_d
    struct list_head *node = NULL;
    struct acpi_pci_link *link = NULL;

    - /* Make sure SCI is enabled again (Apple firmware bug?) */
    - acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);
    list_for_each(node, &acpi_link.entries) {
    link = list_entry(node, struct acpi_pci_link, node);
    if (!link) {

     \ /
      Last update: 2009-02-04 19:51    [W:0.019 / U:3.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site