lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 08/33] netfilter: ctnetlink: fix scheduling while atomic
    2.6.28-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Patrick McHardy <kaber@trash.net>

    commit 748085fcbedbf7b0f38d95e178265d7b13360b44 upstream.

    Caused by call to request_module() while holding nf_conntrack_lock.

    Reported-and-tested-by: Kövesdi György <kgy@teledigit.hu>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/netfilter/nf_conntrack_netlink.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/net/netfilter/nf_conntrack_netlink.c
    +++ b/net/netfilter/nf_conntrack_netlink.c
    @@ -825,13 +825,16 @@ ctnetlink_parse_nat_setup(struct nf_conn
    if (!parse_nat_setup) {
    #ifdef CONFIG_MODULES
    rcu_read_unlock();
    + spin_unlock_bh(&nf_conntrack_lock);
    nfnl_unlock();
    if (request_module("nf-nat-ipv4") < 0) {
    nfnl_lock();
    + spin_lock_bh(&nf_conntrack_lock);
    rcu_read_lock();
    return -EOPNOTSUPP;
    }
    nfnl_lock();
    + spin_lock_bh(&nf_conntrack_lock);
    rcu_read_lock();
    if (nfnetlink_parse_nat_setup_hook)
    return -EAGAIN;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-02-04 19:43    [W:0.022 / U:125.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site