lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL -tip] fix 22 make headers_check - 200901

    * Arnd Bergmann <arnd@arndb.de> wrote:

    > On Wednesday 04 February 2009, Jaswinder Singh Rajput wrote:
    > > On Wed, 2009-02-04 at 17:43 +1100, Herbert Xu wrote:
    > > > > -#include <asm/types.h>
    > > > > +#include <linux/types.h>
    > > > > #include <linux/ioctl.h>
    > > >
    > > > Awesome, you've just broken the userspace build of kvm as the
    > > > file linux/types.h conflicts with sys/types.h.
    > > >
    > >
    > > What I did is absolutely right.
    > >
    > > If there is any conflict then we need to solve it in better way.
    > >
    > > Can you please share what is the conflict and what you are expecting and
    > > what you are getting.
    >
    > I fear that the problem might be more widespread than just kvm.
    > The problem is that <linux/types.h> without __KERNEL_STRICT_NAMES
    > defines the standard types that glibc provides in its own <sys/types.h>,
    > some of them even defined differently (e.g. the size of off_t depends
    > __USE_FILE_OFFSET64).
    >
    > You should be able to do
    >
    > #include <sys/types.h>
    > #define __KERNEL_STRICT_NAMES
    > #include <linux/types.h>
    >
    > or
    >
    > #include <sys/types.h>
    > #include <asm/types.h>
    >
    > but not without the __KERNEL_STRICT_NAMES! This means that the
    > mass-conversion to <linux/types.h> was flawed and should be fixed
    > before 2.6.29 to avoid more trouble.

    agreed.

    Ingo


    \
     
     \ /
      Last update: 2009-02-04 15:21    [W:0.021 / U:211.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site