Messages in this thread | | | Date | Tue, 3 Feb 2009 00:51:41 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] bio.h: If they MUST be inlined, then use __always_inline |
| |
On Sun, 1 Feb 2009 22:07:31 -0200 Alberto Bertogli <albertito@blitiri.com.ar> wrote:
> bvec_kmap_irq() and bvec_kunmap_irq() comments say they MUST be inlined, > so mark them as __always_inline. > > Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar> > --- > include/linux/bio.h | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 0c8e3fb..713ec6e 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -445,7 +445,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly; > * > * This function MUST be inlined - it plays with the CPU interrupt flags. > */ > -static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags) > +static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec, > + unsigned long *flags)
The comment is wrong - this was a sparc requirement, long since removed.
| |