lkml.org 
[lkml]   [2009]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH tip 1/1] blktrace: fix coding style in recent patches

* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Impact: cleanup
>
> I introduced some, then, while testing with checkpatch --file
> block/blktrace.c I saw some long lines and fixed those too, some were
> even from older patches I sent, shame on me ;-\
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

applied to tip:tracing/blktrace, thanks Arnaldo!

btw., there's only one warning remaining in all of blktrace.c:

| CHECK: memory barrier without comment
| #555: FILE: blktrace.c:555:
| + smp_mb();
|
| total: 0 errors, 1 warnings, 1 checks, 1549 lines checked

and here checkpatch is kind of right that we should document this particular
smp_mb(). If you stick a comment in front of that statement, explaining that
barrier, then checkpatch will stop complaining.

Ingo


\
 
 \ /
  Last update: 2009-02-03 16:27    [W:0.030 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site