lkml.org 
[lkml]   [2009]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] bluetooth: add macros for cid channel numbers
From
Date
Hi Gustavo,

you can keep Bluetooth patches on linux-bluetooth only since they have
to go via bluetooth-testing.git first.

You are missing a commit message before the signed-off-by line. I am
serious about that every kernel patch has a proper commit message in
human readable text. No matter how simple the patch might look.

> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
> ---
> include/net/bluetooth/l2cap.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index f566aa1..e7bf331 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -118,6 +118,13 @@ struct l2cap_conn_rsp {
> #define L2CAP_CS_AUTHEN_PEND 0x0001
> #define L2CAP_CS_AUTHOR_PEND 0x0002
>
> +
> +/* cid channel type */

Use /* channel identifier */ here.

> +#define L2CAP_CID_SIGNALING 0x0001
> +#define L2CAP_CID_CONN_LESS 0x0002
> +#define L2CAP_CID_DYN_START 0x0040
> +#define L2CAP_CID_DYN_END 0xffff
> +

And put these above /* connect result */ defs.

Regards

Marcel




\
 
 \ /
  Last update: 2009-02-28 22:33    [W:0.049 / U:1.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site