lkml.org 
[lkml]   [2009]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] x86-64: seccomp: fix 32/64 syscall hole


    On Fri, 27 Feb 2009, Roland McGrath wrote:
    >
    > I don't know any other arch well enough to be sure that TIF_32BIT isn't the
    > wrong test there too. I'd like to leave that worry to the arch maintainers.

    Agreed - it may be that others will want to not use TIF_32BIT too. It
    really does make much more sense to have it as a thread-local status flag
    than as an atomic (and thus expensive to modify) thread-flag, not just on
    x86.

    But I think other architectures will find it easier to see what's going on
    if the code is straightforward and they can just fix their
    'is_compat_task()' function. And:

    > But here is the patch you asked for.

    Yes, this looks much more straightforward.

    And I guess the seccomp interaction means that this is potentially a
    2.6.29 thing. Not that I know whether anybody actually _uses_ seccomp. It
    does seem to be enabled in at least Fedora kernels, but it might not be
    used anywhere.

    Linus


    \
     
     \ /
      Last update: 2009-02-28 18:27    [W:0.021 / U:185.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site