lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] change cpuacct usage percpu format v2
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

cpuacct.usage_percpu shows per cpu usage information via cgroupfs.
It shows all "present" cpus information and "whose information ?"
is explained just by index of data implicitly.

IIRC, there is physical cpu hotplug system and it can remove
cpus and change map. Considering a software which records
this information pediodically(like sar), its better to show id of cpu
in explict way.

Changelog: v1 -> v2
- added ":" instead of " " as split charactor.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
Index: mmotm-2.6.29-Feb26/kernel/sched.c
===================================================================
--- mmotm-2.6.29-Feb26.orig/kernel/sched.c
+++ mmotm-2.6.29-Feb26/kernel/sched.c
@@ -9719,7 +9719,7 @@ static int cpuacct_percpu_seq_read(struc

for_each_present_cpu(i) {
percpu = cpuacct_cpuusage_read(ca, i);
- seq_printf(m, "%llu ", (unsigned long long) percpu);
+ seq_printf(m, "%d:%llu\n", i, (unsigned long long) percpu);
}
seq_printf(m, "\n");
return 0;


\
 
 \ /
  Last update: 2009-02-27 08:33    [W:1.003 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site