lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86-64: seccomp: fix 32/64 syscall hole

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Fri, 27 Feb 2009, Linus Torvalds wrote:
> >
> > Ok, please explain this madness.
> >
> > The whole crazy IS_COMPAT_TASK dance seems to be too messy
> > for words. Why? What's going on?
>
> Ok, I can see what's going on. And it's disgusting.
>
> Just make everybody do that "is_compat_task()" thing. parisc
> already did, and you just made x86-64 do so too. The only
> remaining TIF_32BIT users are powerpc and sparc. So instead of
> having this insane crud, please just add the trivial
> definitions to the two remaining places, and we don't have to
> have this insane mess. Ok?
>
> It is clear that TIF_32BIT is _not_ a generic flag for
> 32/64-bit system calls, so let's stop pretending it is, and
> then having ugly special cases for when it's not.

Seconded.

Ingo


\
 
 \ /
  Last update: 2009-02-28 05:49    [W:0.096 / U:3.856 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site