lkml.org 
[lkml]   [2009]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] tracing: remove unused code

Thanks Luis,

But before I remove this code, I want to move it to be activated by
tracing options. The irqsoff tracer (and other latency tracers) are pretty
useless without it.

-- Steve


On Fri, 27 Feb 2009, Luis Henriques wrote:

> struct file_operations tracing_lt_fops and tracing_lt_open are not used
> anywhere. These are legacy from the /debug/tracing/latency_trace, which has
> been removed in commit 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b
>
> Signed-off-by: Luis Henriques <henrix@sapo.pt>
> ---
> kernel/trace/trace.c | 22 ----------------------
> 1 files changed, 0 insertions(+), 22 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 5db7485..04306a1 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1822,21 +1822,6 @@ static int tracing_open(struct inode *inode, struct file *file)
> return ret;
> }
>
> -static int tracing_lt_open(struct inode *inode, struct file *file)
> -{
> - struct trace_iterator *iter;
> - int ret = 0;
> -
> - iter = __tracing_open(inode, file);
> -
> - if (IS_ERR(iter))
> - ret = PTR_ERR(iter);
> - else
> - iter->iter_flags |= TRACE_FILE_LAT_FMT;
> -
> - return ret;
> -}
> -
>
> static void *
> t_next(struct seq_file *m, void *v, loff_t *pos)
> @@ -1916,13 +1901,6 @@ static struct file_operations tracing_fops = {
> .release = tracing_release,
> };
>
> -static struct file_operations tracing_lt_fops = {
> - .open = tracing_lt_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = tracing_release,
> -};
> -
> static struct file_operations show_traces_fops = {
> .open = show_traces_open,
> .read = seq_read,
> --
> 1.6.1.3
>
>


\
 
 \ /
  Last update: 2009-02-27 21:41    [W:0.068 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site