Messages in this thread | | | Date | Thu, 26 Feb 2009 06:32:54 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: remove update_apic from x86_quirks |
| |
* Yinghai Lu <yinghai@kernel.org> wrote:
> > Impact: cleanup > > x86_quirks->update_apic() calling looks crazy. so try to remove it > 1. every apic take wakeup_cpu member directly > 2. seperate es7000_apic to es7000_apic_cluster > 3. use uv_wakeup_cpu directly > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > --- > arch/x86/include/asm/apic.h | 7 + > arch/x86/include/asm/setup.h | 3 > arch/x86/include/asm/uv/uv.h | 3 > arch/x86/kernel/apic/apic_flat_64.c | 4 - > arch/x86/kernel/apic/bigsmp_32.c | 2 > arch/x86/kernel/apic/es7000_32.c | 127 ++++++++++++++++++++++++++-------- > arch/x86/kernel/apic/numaq_32.c | 10 -- > arch/x86/kernel/apic/probe_32.c | 16 ---- > arch/x86/kernel/apic/probe_64.c | 3 > arch/x86/kernel/apic/summit_32.c | 2 > arch/x86/kernel/apic/x2apic_cluster.c | 2 > arch/x86/kernel/apic/x2apic_phys.c | 2 > arch/x86/kernel/apic/x2apic_uv_x.c | 11 +- > arch/x86/kernel/setup.c | 14 --- > arch/x86/kernel/smpboot.c | 8 -- > 15 files changed, 121 insertions(+), 93 deletions(-)
that's certainly a nice cleanup! Applied to tip:x86/apic, thanks Yinghai!
Ingo
| |