lkml.org 
[lkml]   [2009]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ath5k-devel] [PATCH 1/1] ath5k: fix hw rate index condition
    On Thu, Feb 26, 2009 at 06:39:12PM -0800, Luis R. Rodriguez wrote:
    > Might be worth adding a note why this is the case. Can't we simply avoid
    > this by checking earlier for the error or simply assigning it an actual
    > default _good_ hw rate value?

    I guess an alternative is to initialize to 0, that would count any rx
    packets whose hw rate we don't know about as the base rate, so it would
    probably bias the RC to 1mb, but this is already one of those 'should
    never happen' cases. Also I can't forsee having a rate index > 127 so
    changing the sign is pretty low risk.

    --
    Bob Copeland %% www.bobcopeland.com



    \
     
     \ /
      Last update: 2009-02-27 04:09    [W:0.018 / U:0.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site