Messages in this thread | | | From | "Bob Copeland" <> | Subject | Re: [PATCH 1/1] ath5k: fix hw rate index condition | Date | Thu, 26 Feb 2009 18:15:10 -0500 |
| |
On Thu, 26 Feb 2009 23:44:31 +0100, Jiri Slaby wrote > Make sure we print out a warning when the index is out of bounds, > i.e. even on hw_rix == AR5K_MAX_RATES. > > Also change to WARN and print text with the reported hw_rix.
ACK.
Speaking of, I think there's another potential oob array access at:
if (rxs.rate_idx >= 0 && rs.rs_rate == sc->curband->bitrates[rxs.rate_idx].hw_value_short) rxs.flag |= RX_FLAG_SHORTPRE;
because sc->rate_idx is u8 instead of s8.
-- Bob Copeland %% www.bobcopeland.com
| |