lkml.org 
[lkml]   [2009]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/1] ath5k: fix hw rate index condition
    Date
    On Thu, 26 Feb 2009 23:44:31 +0100, Jiri Slaby wrote
    > Make sure we print out a warning when the index is out of bounds,
    > i.e. even on hw_rix == AR5K_MAX_RATES.
    >
    > Also change to WARN and print text with the reported hw_rix.

    ACK.

    Speaking of, I think there's another potential oob array access at:

    if (rxs.rate_idx >= 0 && rs.rs_rate ==
    sc->curband->bitrates[rxs.rate_idx].hw_value_short)
    rxs.flag |= RX_FLAG_SHORTPRE;

    because sc->rate_idx is u8 instead of s8.

    --
    Bob Copeland %% www.bobcopeland.com




    \
     
     \ /
      Last update: 2009-02-27 00:19    [W:2.470 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site