lkml.org 
[lkml]   [2009]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] uaccess: add copy_word_from_user


On Wed, 25 Feb 2009, H. Peter Anvin wrote:

> Steven Rostedt wrote:
> > This patch creates a copy_word_from_user function that can copy
> > a space delimited word from user space. This puts the code in
> > a new lib/uaccess.c file. This keeps the code in a single location
> > and may be optimized in the future.
>
> I have a bit of an issue with the naming... at least *I* read this as copying
> a machine word, which made me wonder why you didn't just use "get_user". I
> would suggest copy_token_from_user or something like that.

Hehe, I was going to use that name for the function that supplies that
delimiter. But then we have the question. Should the delimiter be a single
character. Do we allow any delimiter? Or simply pass in a function that
will determine the delimiter?

-- Steve



\
 
 \ /
  Last update: 2009-02-26 03:19    [from the cache]
©2003-2011 Jasper Spaans