Messages in this thread | | | Date | Wed, 25 Feb 2009 13:39:47 +0530 | From | Dhaval Giani <> | Subject | Re: [PATCH 2/2] cgroup/memcg show correct file mode |
| |
On Wed, Feb 25, 2009 at 01:33:29PM +0530, Balbir Singh wrote: > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-02-25 16:37:29]: > > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > > > Set correct permission to memcg's file. > > > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > --- > > mm/memcontrol.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Index: mmotm-2.6.29-Feb24/mm/memcontrol.c > > =================================================================== > > --- mmotm-2.6.29-Feb24.orig/mm/memcontrol.c > > +++ mmotm-2.6.29-Feb24/mm/memcontrol.c > > @@ -2218,6 +2218,7 @@ static struct cftype mem_cgroup_files[] > > .name = "usage_in_bytes", > > .private = MEMFILE_PRIVATE(_MEM, RES_USAGE), > > .read_u64 = mem_cgroup_read, > > + .mode = 0444 > > }, > > { > > .name = "max_usage_in_bytes", > > @@ -2240,10 +2241,12 @@ static struct cftype mem_cgroup_files[] > > { > > .name = "stat", > > .read_map = mem_control_stat_show, > > + .mode = 0444 > > }, > > { > > .name = "force_empty", > > .trigger = mem_cgroup_force_empty_write, > > + .mode = 0200 > > }, > > { > > .name = "use_hierarchy", > > @@ -2263,6 +2266,7 @@ static struct cftype memsw_cgroup_files[ > > .name = "memsw.usage_in_bytes", > > .private = MEMFILE_PRIVATE(_MEMSWAP, RES_USAGE), > > .read_u64 = mem_cgroup_read, > > + .mode = 0444 > > }, > > { > > .name = "memsw.max_usage_in_bytes", > > > > > > Yes, please, very much required > > Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
I agree,
Acked-by: Dhaval Giani <dhaval@linux.vnet.ibm.com> -- regards, Dhaval
| |