Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 14/15] bitops: Change the bitmap index from int to unsigned long [frv] | Date | Wed, 25 Feb 2009 23:50:51 +0000 |
| |
H. Peter Anvin <hpa@zytor.com> wrote:
> What makes you say that, in particular?
I prefer it. Actually, I'd prefer it all to be on one line, but some people get picky about the 80 char limit.
Besides, that "static inline" is merely a qualifier to the declaration of the function. The return type, name and args are part of the declaration of the function and belong together more.
> A casual grep finds no less than 3524 instances of "static inline <type>" -- > presumably with a function name following -- and only 447 instances of > "static inline" without a type in the kernel.
But how does it break down between "static inline type\nfunction_name" and "static inline\ntype function_name"? That's more to the point.
David
| |