Messages in this thread | | | Date | Wed, 25 Feb 2009 17:13:10 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/2] tracing/core: introduce per cpu tracing files |
| |
On Wed, Feb 25, 2009 at 02:02:02PM +0100, Ingo Molnar wrote: > > * Frederic Weisbecker <fweisbec@gmail.com> wrote: > > > Impact: split up tracing output per cpu > > > So this patch creates a new directory inside /debug/tracing > > (provided you have a debugfs mountpoint on /debug). Inside > > this directory, you will now find one trace_pipe file, one > > trace file and one latency_trace file per cpu. Which means if > > you have two cpus, you will have: > > > > trace0 > > trace1 > > trace_pipe0 > > trace_pipe1 > > Very nice! I've applied your patches to tip:tracing/ftrace. > > Could you please do one more tweak? The /debug/tracing/per_cpu/ > directory looks a bit cluttered on a 16-way box. It would be a > nicer structure to have per CPU directories, i.e.: > > /debug/tracing/per_cpu/cpu0/trace > /debug/tracing/per_cpu/cpu0/trace_pipe > /debug/tracing/per_cpu/cpu1/trace > /debug/tracing/per_cpu/cpu1/trace_pipe > > etc.
Ah right, the only SMP machine I have has two CPU so I didn't think about that.
> > Besides being easier to handle, this also makes it easy to > extend the list of per CPU attributes as well, without > cluttering the /debug/tracing/per_cpu/ directory. > > Ingo
You're right, I will change that.
Thanks.
| |