Messages in this thread |  | | Date | Wed, 25 Feb 2009 22:20:00 +0800 | | From | Herbert Xu <> | | Subject | Re: [PATCH][trivial] crypto: tcrypt - reduce stack size |
| |
On Wed, Feb 25, 2009 at 02:48:19PM +0100, Frank Seidel wrote: > From: Frank Seidel <frank@f-seidel.de> > > Applying kernel janitors todos (printk calls need KERN_* > constants on linebeginnings, reduce stack footprint where > possible) to tcrypts test_hash_speed (where stacks > memory footprint was very high (on i386 1184 bytes to > 292 now). > > Signed-off-by: Frank Seidel <frank@f-seidel.de> > --- > crypto/tcrypt.c | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) > > --- a/crypto/tcrypt.c > +++ b/crypto/tcrypt.c > @@ -396,26 +396,34 @@ static void test_hash_speed(const char * > struct scatterlist sg[TVMEMSIZE]; > struct crypto_hash *tfm; > struct hash_desc desc; > - char output[1024];
How about just making it static?
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|  |