Messages in this thread Patch in this message | | | Date | Wed, 25 Feb 2009 14:38:54 +0100 | From | Roel Kluin <> | Subject | [PATCH] aoe: error printed 1 too early |
| |
with while (i-- > 0); i reaches -1 after the loop, so the test below is printed one too early: 0 still means success.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index cc25057..eeea477 100644 --- a/drivers/block/aoe/aoedev.c +++ b/drivers/block/aoe/aoedev.c @@ -173,7 +173,7 @@ skbfree(struct sk_buff *skb) return; while (atomic_read(&skb_shinfo(skb)->dataref) != 1 && i-- > 0) msleep(Sms); - if (i <= 0) { + if (i < 0) { printk(KERN_ERR "aoe: %s holds ref: %s\n", skb->dev ? skb->dev->name : "netif",
| |