Messages in this thread |  | | Date | Wed, 25 Feb 2009 14:26:28 +0100 (CET) | | From | Geert Uytterhoeven <> | | Subject | Re: [PATCH] crypto: compress - Add pcomp interface |
| |
On Wed, 25 Feb 2009, Herbert Xu wrote: > On Mon, Feb 23, 2009 at 06:32:19PM +0100, Geert Uytterhoeven wrote: > > > > Is the below (on top of my last patch series) what you have in mind? > > Looks great to me!
OK.
> > Notes: > > - I had to drop the `const' from the `params' pointers of > > pcomp_alg.{,de}compress_setup(). > > Trying to make nla_parse() take const nlattr structures instead seems to > > open a big can of worms... > > I don't think that's a big deal. > > > - I should add a dependency of CONFIG_CRYPTO_ZLIB on CONFIG_NET (due to the > > need for nla_parse()). However, I don't like that. > > Dave has OKed it for the attribute stuff to be moved into lib. > So if you want to tackle that then be my guest :) Otherwise I'll > look into moving it.
I already have a patch for that. I'll fold the netlink parsing into the original series and will resubmit.
With kind regards,
Geert Uytterhoeven Software Architect
Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/
A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |