lkml.org 
[lkml]   [2009]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch][rfc] fs: move bdev code out of buffer.c
    On Wed, Feb 25, 2009 at 05:35:43AM -0500, Jeff Garzik wrote:
    > Nick Piggin wrote:
    > >Move some block device related code out from buffer.c and put it in
    > >block_dev.c. I'm trying to move non-buffer_head code out of buffer.c
    > >
    > >Is this OK?
    > >
    > >---
    > > fs/block_dev.c | 146
    > > ++++++++++++++++++++++++++++++++++++++++++++
    > > fs/buffer.c | 145
    > > -------------------------------------------
    > > include/linux/buffer_head.h | 7 --
    > > include/linux/fs.h | 7 ++
    > > 4 files changed, 153 insertions(+), 152 deletions(-)
    >
    > If you are going to churn all this old code, maybe the blkdev stuff
    > better belongs in block/ dir?

    If you have a look at it, it's all dealing with buffercache and
    filesystem metadata I think. So I think fs/block_dev.c is the
    right place for it.

    block/ shouldn't know about filesystems or pagecache.



    \
     
     \ /
      Last update: 2009-02-25 11:57    [W:0.029 / U:30.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site