lkml.org 
[lkml]   [2009]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:tracing/hw-branch-tracing] tracing/hw-branch-tracing: convert bts-tracer mutex to a spinlock

* Metzger, Markus T <markus.t.metzger@intel.com> wrote:

> > static void trace_bts_prepare(struct trace_iterator *iter)
> > {
> >- mutex_lock(&bts_tracer_mutex);
> >+ spin_lock(&bts_tracer_lock);
> >
> > on_each_cpu(trace_bts_cpu, iter->tr, 1);
> >
> >- mutex_unlock(&bts_tracer_mutex);
> >+ spin_unlock(&bts_tracer_lock);
> > }
>
> Whereas start/stop are relatively fast, the above operation is
> rather expensive. Would it make sense to use
> schedule_on_each_cpu() instead of on_each_cpu()?

it's perfectly fine to do that on_each_cpu() under the spinlock.
schedule_on_each_cpu() would likely be more expensive - and for
no good reason.

Ingo


\
 
 \ /
  Last update: 2009-02-25 11:01    [W:0.054 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site