[lkml]   [2009]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 02/10] bootmem: clean up arch-specific bootmem wrapping

    Johannes Weiner wrote:
    > This won't suffice as reserve_bootmem() doesn't use
    > alloc_bootmem_core(), so now you effectively removed the node-0
    > restriction for reserve_bootmem() on this configuration.

    Ah... right. :-(

    > I wonder why this setup wants to register several bootmem nodes but
    > only use node 0, anyway. Does someone remember? :)
    >> -static void * __init alloc_bootmem_core(struct bootmem_data *bdata,
    >> +static void * __init __alloc_bootmem_core(struct bootmem_data *bdata,
    >> unsigned long size, unsigned long align,
    >> unsigned long goal, unsigned long limit)
    > static but you refer to it in arch/x86/include/mmzone_32.h.

    Yeah, that's why it's a macro. I thought about putting it into a
    separate header file, say, asm/bootmem-wrapper.h and including it only
    from bootmem.c but it looked like an overkill, so...



     \ /
      Last update: 2009-02-24 12:43    [W:0.166 / U:4.248 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site