lkml.org 
[lkml]   [2009]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH tj-percpu] percpu: add __read_mostly to variables which are mostly read only
    Most global variables in percpu allocator are initialized during boot
    and read only from that point on. Add __read_mostly as per Rusty's
    suggestion.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    ---
    Added to #tj-percpu.

    mm/percpu.c | 16 ++++++++--------
    1 files changed, 8 insertions(+), 8 deletions(-)

    diff --git a/mm/percpu.c b/mm/percpu.c
    index 9ac0198..5954e7a 100644
    --- a/mm/percpu.c
    +++ b/mm/percpu.c
    @@ -83,18 +83,18 @@ struct pcpu_chunk {
    struct page *page[]; /* #cpus * UNIT_PAGES */
    };

    -static int pcpu_unit_pages;
    -static int pcpu_unit_size;
    -static int pcpu_chunk_size;
    -static int pcpu_nr_slots;
    -static size_t pcpu_chunk_struct_size;
    +static int pcpu_unit_pages __read_mostly;
    +static int pcpu_unit_size __read_mostly;
    +static int pcpu_chunk_size __read_mostly;
    +static int pcpu_nr_slots __read_mostly;
    +static size_t pcpu_chunk_struct_size __read_mostly;

    /* the address of the first chunk which starts with the kernel static area */
    -void *pcpu_base_addr;
    +void *pcpu_base_addr __read_mostly;
    EXPORT_SYMBOL_GPL(pcpu_base_addr);

    /* the size of kernel static area */
    -static int pcpu_static_size;
    +static int pcpu_static_size __read_mostly;

    /*
    * One mutex to rule them all.
    @@ -112,7 +112,7 @@ static int pcpu_static_size;
    */
    static DEFINE_MUTEX(pcpu_mutex);

    -static struct list_head *pcpu_slot; /* chunk list slots */
    +static struct list_head *pcpu_slot __read_mostly; /* chunk list slots */
    static struct rb_root pcpu_addr_root = RB_ROOT; /* chunks by address */

    static int __pcpu_size_to_slot(int size)
    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-02-24 06:29    [W:5.342 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site