Messages in this thread |  | | Date | Wed, 25 Feb 2009 10:56:05 +0800 | | From | Herbert Xu <> | | Subject | Re: [PATCH] crypto: compress - Add pcomp interface |
| |
On Mon, Feb 23, 2009 at 06:32:19PM +0100, Geert Uytterhoeven wrote: > > Is the below (on top of my last patch series) what you have in mind?
Looks great to me!
> Notes: > - I had to drop the `const' from the `params' pointers of > pcomp_alg.{,de}compress_setup(). > Trying to make nla_parse() take const nlattr structures instead seems to > open a big can of worms...
I don't think that's a big deal.
> - I should add a dependency of CONFIG_CRYPTO_ZLIB on CONFIG_NET (due to the > need for nla_parse()). However, I don't like that.
Dave has OKed it for the attribute stuff to be moved into lib. So if you want to tackle that then be my guest :) Otherwise I'll look into moving it.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|  |