Messages in this thread | | | Date | Tue, 24 Feb 2009 14:48:00 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 4/4] mqueue namespace: adapt sysctl |
| |
On Wed, 25 Feb 2009 01:32:45 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > > +proc_handler *proc_mq_dointvec = NULL; > > > +proc_handler *proc_mq_dointvec_minmax = NULL; > > > +#endif > > > > looks odd. Was this > > > > --- a/ipc/mq_sysctl.c~mqueue-namespace-adapt-sysctl-update-fix > > +++ a/ipc/mq_sysctl.c > > @@ -52,8 +52,8 @@ static int proc_mq_dointvec_minmax(ctl_t > > lenp, ppos); > > } > > #else > > -proc_handler *proc_mq_dointvec = NULL; > > -proc_handler *proc_mq_dointvec_minmax = NULL; > > +#define proc_mq_dointvec NULL > > +#define proc_mq_dointvec_minmax NULL > > #endif > > I hope, not. > > "#define foo NULL" is the least intrusive thing.
well the original code would have spat a warning at compile time then tried to execute code from BSS at runtime, methinks.
But I can't be assed working out how to disable CONFIG_SYSCTL to test that. Gawd I hate `select'.
| |