lkml.org 
[lkml]   [2009]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/6] x86, ftrace, hw-branch-tracer: support hotplug cpus

* Markus Metzger <markus.t.metzger@intel.com> wrote:

> Support hotplug cpus.

> +static int __cpuinit bts_hotcpu_handler(struct notifier_block *nfb,
> + unsigned long action, void *hcpu)
> +{
> + unsigned int cpu = (unsigned long)hcpu;
> +
> + mutex_lock(&bts_tracer_mutex);

This is buggy: CPU hotplug handlers must not sleep (they are
called with irqs disabled), while this code does a mutex_lock()
which can sleep.

Ingo


\
 
 \ /
  Last update: 2009-02-24 20:39    [W:0.052 / U:1.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site