lkml.org 
[lkml]   [2009]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/19] Simplify the check on whether cpusets are a factor or not
    On Tue, Feb 24, 2009 at 12:27:02PM -0500, Christoph Lameter wrote:
    > On Tue, 24 Feb 2009, Mel Gorman wrote:
    >
    > > @@ -1420,8 +1429,8 @@ zonelist_scan:
    > > if (NUMA_BUILD && zlc_active &&
    > > !zlc_zone_worth_trying(zonelist, z, allowednodes))
    > > continue;
    > > - if ((alloc_flags & ALLOC_CPUSET) &&
    > > - !cpuset_zone_allowed_softwall(zone, gfp_mask))
    > > + if (alloc_cpuset)
    > > + if (!cpuset_zone_allowed_softwall(zone, gfp_mask))
    > > goto try_next_zone;
    >
    > Hmmm... Why remove the && here? Looks more confusing to me.
    >

    At the time, just because it was what I was splitting out. Chances are
    it makes no difference to the assembly. I'll double check and if not,
    switch it back.

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2009-02-24 18:59    [W:0.022 / U:60.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site