Messages in this thread |  | | Date | Mon, 23 Feb 2009 22:46:19 +0100 (CET) | | From | Jesper Juhl <> | | Subject | Re: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c |
| |
On Mon, 23 Feb 2009, Paul Menage wrote:
> On Sun, Feb 22, 2009 at 2:05 PM, Jesper Juhl <jj@chaosbits.net> wrote: > > Hi, > > > > Here's a small patch for kernel/cgroup.c > > > > Removes a few pointless tests of pointer == 0 before kfree() in > > kernel/cgroup.c. > > If the pointer we hand to kfree() is 0, then kfree() is a noop, so there > > is no need to test. > > > > Reduces object file size a bit : > > > > Before: > > $ size kernel/cgroup.o > > text data bss dec hex filename > > 21593 7804 4924 34321 8611 kernel/cgroup.o > > After: > > $ size kernel/cgroup.o > > text data bss dec hex filename > > 21537 7744 4924 34205 859d kernel/cgroup.o > > Thanks. I'm a bit surprised that it also shrunk the data segment size > (and in fact, by more than the text segment size). Any idea how that > came about? > Can't say I've got a good explanation for that, no.
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
|  |