lkml.org 
[lkml]   [2009]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove some pointless conditionals before kfree() in kernel/cgroup.c
On Mon, 23 Feb 2009, Paul Menage wrote:

> On Sun, Feb 22, 2009 at 2:05 PM, Jesper Juhl <jj@chaosbits.net> wrote:
> > Hi,
> >
> > Here's a small patch for kernel/cgroup.c
> >
> > Removes a few pointless tests of pointer == 0 before kfree() in
> > kernel/cgroup.c.
> > If the pointer we hand to kfree() is 0, then kfree() is a noop, so there
> > is no need to test.
> >
> > Reduces object file size a bit :
> >
> > Before:
> > $ size kernel/cgroup.o
> > text data bss dec hex filename
> > 21593 7804 4924 34321 8611 kernel/cgroup.o
> > After:
> > $ size kernel/cgroup.o
> > text data bss dec hex filename
> > 21537 7744 4924 34205 859d kernel/cgroup.o
>
> Thanks. I'm a bit surprised that it also shrunk the data segment size
> (and in fact, by more than the text segment size). Any idea how that
> came about?
>
Can't say I've got a good explanation for that, no.

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please http://www.expita.com/nomime.html
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html



\
 
 \ /
  Last update: 2009-02-23 22:49    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog